Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix merge into master: Rule amendment - Remove role abandonment aHelp requirement. (#33287) #33324

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Hotfix merge into master: Rule amendment - Remove role abandonment aHelp requirement. (#33287) #33324

merged 1 commit into from
Nov 15, 2024

Conversation

slarticodefast
Copy link
Member

Merges the Hotfix from #33287 into master.
Reminder: This should not be squash merged.

@Titian3 @slarticodefast
Rule amendment - Remove role abandonment aHelp requirement. (#33287)
530a741 
* Role abandonment aHelp requirement.

* disable roundstart chat message

---------

Co-authored-by: slarticodefast <[email protected]>
@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Nov 15, 2024
@SaphireLattice SaphireLattice added P1: High Priority: Higher priority than other items, but isn't an emergency. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. Intent: Hotfix PR Intent: Something that should be applied via hotfix procedure. A: Rules Area: Changes to the default server rules as provided by Wizden. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
SaphireLattice
SaphireLattice approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SaphireLattice SaphireLattice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already checked it in #33287, commit tree looks fine. Also I think this should just count as a "technical PR" as it exists only to bring master back in line with stable.

Should probably change the hotfix doc to outline this should just be instantly merged in

Also I have no clue but how protected is master branch? Could probably just merge stuff in directly without a PR.

@SaphireLattice SaphireLattice merged commit f75be07 into master Nov 15, 2024
15 checks passed
@Thinbug0 Thinbug0 mentioned this pull request Nov 19, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaphireLattice SaphireLattice SaphireLattice approved these changes

Assignees
No one assigned
Labels
A: Rules Area: Changes to the default server rules as provided by Wizden. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. Intent: Hotfix PR Intent: Something that should be applied via hotfix procedure. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slarticodefast @SaphireLattice @Titian3